Deprecated LDAP config syntax broken on 9.4.2 and up

Installations using deprecated LDAP config syntax from pre-GitLab 7.4 may have broken LDAP connections starting with 9.4.2.

This is a showstopper for those affected since their users cannot log in, see https://gitlab.com/gitlab-org/gitlab-ee/issues/3082#note_37284050. But the syntax has been deprecated for awhile, so I'm not sure what exactly should be done here.

From https://gitlab.com/help/administration/auth/ldap.md#configuration:

Prior to version 7.4, GitLab used a different syntax for configuring LDAP integration. The old LDAP integration syntax still works but may be removed in a future version. If your gitlab.rb or gitlab.yml file contains LDAP settings in both the old syntax and the new syntax, only the old syntax will be used by GitLab.

That sounds like fair warning, so maybe now we could change it to:

Prior to version 7.4, GitLab used a different syntax for configuring LDAP integration. The old LDAP integration syntax does not work beginning with version 9.4.2. Before version 9.4.2, if your gitlab.rb or gitlab.yml file contains LDAP settings in both the old syntax and the new syntax, only the old syntax will be used by GitLab.

Also note that this other doc page mentions deprecated syntax at the bottom https://docs.gitlab.com/omnibus/settings/ldap.html.

mentioned in issue #3082 (closed)

does this mean 9.4.4 with updated syntax should work for my deployment of EE? How and why doesn't this impact my CE deployment?

@mkozono Before we do decide to simply drop it, it would be great to know exactly why it broke.

@johneismeier The impact should be the same between CE and EE.

/cc @DouweM

@mkozono Why did it break? Is it possible to retain backward compatibility?

Let's close this as a dupe of https://gitlab.com/gitlab-org/gitlab-ee/issues/3144.

closed

just upgraded to 9.5.0 expecting EE to finally be repaired but still no luck. Can this issue be re-opened? Do I really need to reformat the gitlab.rb to embed yaml config for LDAP ?

==> /var/log/gitlab/unicorn/unicorn_stdout.log <==
bundler: failed to load command: unicorn (/opt/gitlab/embedded/bin/unicorn)
I, [2017-08-23T08:48:32.257978 #25599]  INFO -- omniauth: (ldapmain) Callback phase initiated.
E, [2017-08-23T08:48:32.485367 #25599] ERROR -- omniauth: (ldapmain) Authentication failure! ldap_error: Errno::ECONNRESET, Connection reset by peer @ io_fillbuf - fd:22 

Hey @johneismeier I'm looking at https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2690 and it has not yet been picked into any releases. I didn't complete it in time for 9.5.0 or 9.5.1, but since it is merged and ready to go, I expect it will be in 9.5.2. Apologies for the delay.

Thanks Michael, I just assumed the next release was all set without checking.