Make sure notification email footer correctly described reason for receiving.

The footer currently always reads "You're receiving this notification because you are a member of the GitLab.org / GitLab Community Edition project team.", while this is not the case for the majority of people contributing to GitLab CE who are simply participating in the specific issue or merge request the notification is sent out for.

causing us confusion as well

I spent about 5m trying to figure out why I was getting an email about being a member of a group I didn't belong to, when the issue was that a teammate of mine @group'd a group I was apart of that caused me to be attached to the issue but not the group.

It would be nice if the email stated I am receiving this email because someone @group'd me instead of receiving this email because I'm apart of a group I don't belong to.

Thanks!

I looked at the code and it looks like this may be a problem for other types of emails sent from the notification service as well. The recipients come from many streams (subscribers, project watchers, mentions, etc) and the fix would involve keeping track of where a recipient came from / passing it to each mailer template.

causing us confusion as well

this would lead people to classify messages as spam

@JobV Please give this a milestone.

Milestone changed to 8.0

Not sure if this is easily done. @blaskovicz describes the point well, but I worry about the amount of change this requires.

For now I assumed this is a relatively easy-fix. If not, we should consider moving it to a later release.

"You're receiving this notification because you have an account on gitlab.example.com"

"You're receiving this notification because you contributed/subscribed to this project/thread"

Let's combine it:
"You're receiving this notification because you have an account on gitlab.example.com and contributed/subscribed to this project/thread"

Let's use GitLab vernacular and go with "participated" rather than "contributed" :) "thread" could be replaced by "discussion". Note that this still doesn't cover the case where the recipient is the assignee.

(off-topic: Is there a reason why I receive all new replies twice?)

@mrtux there isn't, it's annoying, we're aware of it, we're looking into it :)

This is a quick fix. Should be possible to do in 8.2.

Milestone changed to 8.2

mentioned in merge request gitlab-foss!1409 (merged)

@JobV The sentence was removed entirely in gitlab-foss!1409 (merged). I think this is good enough, we don't need to mention the actual reason, in most cases the user will know that themselves anyway, or be able to figure it out quickly. Agree that we can close this issue?

We have problems with our email being marked as SPAM. I expect every automated email to inform me why I'm receiving it. Some people might not have used GitLab for 2 years or their account might be automatically created.

I think we should have a message, but it should be generic enough so that it works in every case.

"You receive this email because of you account on HOSTNAME. To receive less emails please adjust your notification settings."

Milestone changed to 8.1

@JobV Moving this to 8.1 since we should not ship without a message.

+1 cc @dzaporozhets @DouweM

Reassigned to @DouweM

@sytses Restored footer text in gitlab-foss!1640 (merged).

@sytses gitlab-foss!1640 (merged) to restore the footer text was merged.

Assignee removed

mentioned in issue gitlab-foss#3437 (closed)

Milestone removed

Added gitlab-foss405125 gitlab-foss18332 labels

Added ~874211 label

moved from gitlab-foss#1366 (moved)