Allow `LDAPGroupSync` to accept a group name/id to sync individually
In preparation for a 'sync now' button in group settings, we need to add support for passing a group name/id to the LDAPGroupSync class.
cc/ @jacobvosmaer fyi
Activity
mentioned in issue #400 (closed)
mentioned in merge request !229 (merged)
Given gitlab-org/gitlab-ce!3383, I think the lease should only be 15 minutes for each group that is synced. Also, bypass the lease altogether when an individual group is passed in.
cc/ @jacobvosmaer
@dblessing I agree with both suggested changes (15 second lease timeout and lease bypass for single groups).
Milestone changed to 8.8
@DouweM @jacobvosmaer I think we're going to need state machine to properly show the user whether the group can be synced or is currently syncing, failed, etc. In that case, I wonder whether state machine would be sufficient instead of an exclusive lease. We could do a combination and tell the individual group sync to ignore the exclusive lease but is it really worth it?
@dblessing In that case, I don't think we need the exclusive lease. We do need a way to recover from a stuck state machine, when the Sidekiq worker is killed for some reason without cleaning up.
Milestone changed to 8.9
mentioned in issue #666
Removed feature proposal ldap labels
Milestone changed to %8.10
Added feature proposal ldap labels
mentioned in merge request !500 (closed)
Milestone changed to %8.11
mentioned in merge request !636 (merged)
@dblessing what is the status of this issue? I see a number of things linked.
@JobV !636 (merged) is being reviewed now. Should make it in and that will close this issue.
Status changed to closed by merge request !636 (merged)
mentioned in commit d9e44d8f
mentioned in commit bc9fc90b
Mentioned in commit d9e44d8f
