Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 9,362
    • Issues 9,362
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #5761
Closed
Open
Issue created Aug 10, 2016 by username-removed-655612@lars7

Slack notifications: Rename misleading #general

Description

Following up on issue gitlab-foss#20707 (closed) , the default settings for the slack integration page are misleading. According to the slack service documentation, the default channel is "#general". This has two issues:

  • a hashtag in front of a word may be a channel, but can also simply denote a topic (tagging)
  • when entering a channel, the documentation informs you, that it has to be done without a hashtag in front - but the placeholder does have one
  • when using with the integrated mattermost, adding an incoming webhook requires you to set a channel for this webhook. Setting a non-existing channel here does not result in an error message, but the webhook to simply not work.

Also, clicking the "Test Integration" button (secondary option on the page) does not save any data and discards all changes without notice.

Proposal

  • Set the placeholder to "channel..." instead of "#general"
  • Rename the secondary action button from "Test Integration" to "Save and Send Test Notification" and make the button also save current changes
  • Properly handle error messages during test integration (http status is 500, if the channel does not exist)
Assignee
Assign to
Time tracking