RepositoryUpdateMirrorWorker::UpdateMirrorError: Rugged::InvalidError: cannot set empty URL

https://sentry.gitlap.com/gitlab/gitlabcom/issues/10257/

Rugged::InvalidError: cannot set empty URL
  lib/gitlab/metrics/instrumentation.rb:155:in `block in remote_add'
    trans.method_call_for(#{label.to_sym.inspect}).measure { super }
  lib/gitlab/metrics/method_call.rb:23:in `measure'
    retval = yield
  lib/gitlab/metrics/instrumentation.rb:155:in `remote_add'
    trans.method_call_for(#{label.to_sym.inspect}).measure { super }
  app/models/repository.rb:219:in `add_remote'
    raw_repository.remote_add(name, url)
  lib/gitlab/metrics/instrumentation.rb:155:in `block in add_remote'
    trans.method_call_for(#{label.to_sym.inspect}).measure { super }
...
(48 additional frame(s) were not displayed)

RepositoryUpdateMirrorWorker::UpdateMirrorError: Rugged::InvalidError: cannot set empty URL
  app/workers/repository_update_mirror_worker.rb:26:in `rescue in perform'
    raise UpdateMirrorError, "#{ex.class}: #{Gitlab::UrlSanitizer.sanitize(ex.message)}"
  app/workers/repository_update_mirror_worker.rb:12:in `perform'
    begin
  lib/gitlab/sidekiq_middleware/request_store_middleware.rb:6:in `call'
    yield
  lib/gitlab/sidekiq_middleware/memory_killer.rb:17:in `call'
    yield
  lib/gitlab/sidekiq_middleware/arguments_logger.rb:6:in `call'
    yield
...
(26 additional frame(s) were not displayed)

Added gitlab-org/gitlab-ce~17876 label

Milestone changed to gitlab-org/gitlab-ce%27

It seems we have some empty import_url values

Moved from gitlab-org/gitlab-ce#21386

Reassigned to @eReGeBe

I was able to create a project with mirror = true and import_url = "" by doing the following:

• Go to create new project
• On the import sources click on "Repo by Url"
• Enter a whitespace as the repo_url and check "Mirror repository"
• Click on "Create Project"

So we need to:

• Add validations to the model
• Add a migration to update to mirror=false all projects with empty import_url
• On the interface, it would be good to either clean or ignore the mirror input when you toggle of "Repo by Url"

Started branch 939-repositoryupdatemirrorworker-updatemirrorerror-rugged-invaliderror-cannot-set-empty-url

mentioned in merge request !700 (closed)

Mentioned in commit 84ff13a8

Mentioned in commit 20d19edc