[EE] Update Rubocop to Ruby 2.3
/cc @rspeicher @smcgivern
Merge request reports
Activity
assigned to @rspeicher
CE: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8994
Not sure why these are assigned to different people.
@zj FYI the branch should be named
zj-drop-ruby-21-tests-ee
if you ever want theee_compat_check
of gitlab-ce!8994 to pass.Edited by username-removed-128633@rymai Ill keep that in mind for the next time :)
@rspeicher It doesn't matter who merges it really, only for the graphs which I never look at. :)
@zj Well it's usually easier if the person who merges the CE MR then goes and merges the EE version.
Did you really think I was complaining about clicking a button? I meant logistically easier. The CE version should be merged first, so it's less complicated if the same person who reviews the CE version, and merges it, then goes and merges the EE version.
When you assign them to two different people, you're splitting the review process. What if I had notes on this version, and then Stan merges the CE version before you address the notes in both?
@rspeicher Sorry for asking.
assigned to @zj
assigned to @rymai
enabled an automatic merge when the pipeline for af6d10ba succeeds
@rymai Rebased against master, hope this works
added 178 commits
-
af6d10ba...ef7dd1e9 - 177 commits from branch
master
- 6155d8e7 - Update rubocop to ruby 2.3
-
af6d10ba...ef7dd1e9 - 177 commits from branch
@zj Ok, I used the
/merge
command but apparently it didn't work. Re-setting to MWPS anyway, thanks!enabled an automatic merge when the pipeline for 6155d8e7 succeeds