Re-compile merge request Vue app after jQuery ajax
Previously the code was setup to not send a request to the backend if approvals is setup, this changes that by always sending this request (like it should). & then after getting & replacing the HTML the Vue app re-compiles itself.
This fixes a bug that was stopping certain merge requests from changing content away from 'Checking ability to merge automatically' check https://gitlab.com/issue-reproduce/persistent-mr-spinners/merge_requests/1 to see the bug in action.
Merge request reports
Activity
The code might not be the best but it is sort of stopping gap that is allowing our existing jQuery merge request code to do its part while the Vue app also does its part. This will not be required once the widget is built with Vue.
Edited by Phil Hughesadded 5 commits
-
896da9ad...f5c5e336 - 4 commits from branch
master
- 2333ef3f - Re-compile merge request Vue app after jQuery ajax
-
896da9ad...f5c5e336 - 4 commits from branch
added 12 commits
-
2333ef3f...e5eebeb8 - 11 commits from branch
master
- c95ec812 - Re-compile merge request Vue app after jQuery ajax
-
2333ef3f...e5eebeb8 - 11 commits from branch
assigned to @filipa
@iamphill This only happens in ee?
🤔 This only happens in ee?
🤔 @filipa yep, since EE only has the approvals Vue app.
@smcgivern do we need to backport this change to 8.16?
Thanks @iamphill! I think this should be in 8.16 as well as 8.17, as the bug was introduced in 8.16.
changed milestone to %8.16
changed milestone to %8.17
@rdavila Did this make it into 8.17.1?
@markglenfletcher yes, it was shipped with
8.17.1
mentioned in commit adf7581d
mentioned in commit 3927ef85