Skip to content

Port of "API: Make the /notes endpoint work with noteable iid instead of id" to EE

Toon Claes requested to merge tc-api-remove-comments-endpoint-ee into master

What does this MR do?

EE port of gitlab-org/gitlab-ce!10258.

It cleans up some things that were forgotten during the implementation of API V4:

  • Remove the newly added GET /projects/:id/merge_requests/:merge_request_iid/comments and POST /projects/:id/merge_requests/:merge_request_iid/comments endpoints
  • Change GET /projects/:id/merge_requests/:merge_request_id/notes and POST /projects/:id/merge_requests/:merge_request_id/notes to GET /projects/:id/merge_requests/:merge_request_iid/notes and POST /projects/:id/merge_requests/:merge_request_iid/notes (i.e. merge_request_iid instead merge_request_id), same
  • Keep GET /v3/projects/:id/merge_requests/:merge_request_id/notes and POST /v3/projects/:id/merge_requests/:merge_request_id/notes

And also (i.e. merge_request_iid instead merge_request_id):

  • Change GET /projects/:id/merge_requests/:merge_request_id/approvals to GET /projects/:id/merge_requests/:merge_request_iid/approvals
  • Change POST /projects/:id/merge_requests/:merge_request_id/approve to POST /projects/:id/merge_requests/:merge_request_iid/approve
  • Change POST /projects/:id/merge_requests/:merge_request_id/unapprove to POST /projects/:id/merge_requests/:merge_request_iid/unapprove

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ee#1875

Merge request reports