Skip to content

Fix MR approvals sentence

username-removed-443319 requested to merge fix-mr-approval-sentence into master

What does this MR do?

Fix the approvals sentence when all remaining approvers have to approve the MR.

Are there points in the code the reviewer needs to double check?

Don't think so.

Why was this MR needed?

We had this logic in the backend, but then rewrote the FE in vue and didn't capture every case.

Screenshots (if relevant)

image

image

image

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/2272.

Merge request reports