Update the elasticsearch image we use
What does this MR do?
Changes from elasticsearch
to docker.elastic.co/elasticsearch/elasticsearch
Are there points in the code the reviewer needs to double check?
We also squeeze the memory use further, and set an upper bound on fielddata usage, to try to reduce ENOMEM errors.
Does this MR meet the acceptance criteria?
- Tests
-
All builds are passing
-
-
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
added 249 commits
-
87983651...0748960b - 248 commits from branch
gitlab-org:master
- e09c20f0 - Update the elasticsearch image we use
-
87983651...0748960b - 248 commits from branch
added 179 commits
-
e09c20f0...ebe5fef5 - 178 commits from branch
gitlab-org:master
- bf47bddb - Update the elasticsearch image we use
-
e09c20f0...ebe5fef5 - 178 commits from branch
added 32 commits
-
bf47bddb...194ff1a7 - 31 commits from branch
gitlab-org:master
- c716167e - Update the elasticsearch image we use
-
bf47bddb...194ff1a7 - 31 commits from branch
added 3 commits
-
c716167e...407d8af4 - 2 commits from branch
gitlab-org:master
- d3cb55ee - Update the elasticsearch image we use
-
c716167e...407d8af4 - 2 commits from branch
added 520 commits
-
d3cb55ee...4f7c11b4 - 519 commits from branch
gitlab-org:master
- bf19cd64 - Update the elasticsearch image we use
-
d3cb55ee...4f7c11b4 - 519 commits from branch
added 1162 commits
-
bf19cd64...0d6ec15f - 1161 commits from branch
gitlab-org:master
- db6672ca - Update the elasticsearch image we use
-
bf19cd64...0d6ec15f - 1161 commits from branch
added blocked label
added 6598 commits
- db6672ca...9bd93670 - 6597 commits from branch
gitlab-org:master
- f10cde5a - Update the elasticsearch image we use
- db6672ca...9bd93670 - 6597 commits from branch
mentioned in issue #2277 (closed)
assigned to @nick.thomas
added 555 commits
- f10cde5a...d42d0e8a - 554 commits from branch
gitlab-org:master
- 3f1f8f11 - Update the elasticsearch image we use
- f10cde5a...d42d0e8a - 554 commits from branch
removed blocked label
@vsizov this passes. WDYT?
assigned to @vsizov
LGTM, but I'm surprised how specs passed because we have to whitelist the new host for webmock... Well if specs passed, I'm wrong then.
We could also use service alias I guess https://docs.gitlab.com/ce/ci/docker/using_docker_images.html
PS @nick.thomas You have LGTM and some random thoughts, it's up to you what to do, merge it or change something.
assigned to @nick.thomas
@vsizov we whitelist
ELASTIC_URL
here: https://gitlab.com/gitlab-org/gitlab-ee/blob/master/spec/support/webmock.rb#L7I'd still prefer to disable X-Pack (does it use more RAM?) but fixing that runner bug is going to be difficult and the
elastic
images on docker hub are deprecated.@smcgivern can you review as maintainer?
assigned to @smcgivern
changed milestone to %9.5
mentioned in commit 6d8ab0e5