Encapsulate service desk error in Error()
What does this MR do?
- Pull out fix from @ClemMakesApps in CE upstream to wrap
Response
object inError
and adhere to prop type defined.
Are there points in the code the reviewer needs to double check?
- The prop type warning was always an issue but the only way
fetchError
is set is if the request fails. The request seemed to only start failing recently😕 - The current suspicion is that the middleware that blocks requests after a test finishes is wreaking some havoc, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1837#note_29140228
Why was this MR needed?
- Prop type check warnings causing test failures
Does this MR meet the acceptance criteria?
- Tests
-
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together