WIP: Add ee dispatcher
What does this MR do?
CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11380
Add an ee dispatcher to limit ee conflicts when dealing with dispatcher
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Activity
Docs for this: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11354
assigned to @iamphill
- app/assets/javascripts/ee/dispatcher.js 0 → 100644
1 const Dispatcher = { These dispatchers works in the exact same way, they just look different. Its an object instead of a class. The extra functionality in the original dispatcher is just some strange import-specific stuff. They are both called when the document is ready and both immediately take the
body[data-page]
variable to use in a switch statement.I'd still prefer if this kept to the same standard by using a class. Also keeps to our docs https://docs.gitlab.com/ce/development/fe_guide/design_patterns.html#singletons
I know it was mentioned on the frontend call, I just wasn't around for it. But our docs at the moment say to use classes, so we should.
Good point. We spoke about it and there seemed to be an understanding about it, but we should confirm it in docs. I opened this issue https://gitlab.com/gitlab-org/gitlab-ce/issues/32028 but it didn't get any activity so I'll just open an MR and see what people have to discuss. I'm going to put this on hold until there is a definitive answer.
- Resolved by Luke "Jared" Bennett
assigned to @lbennett
CE port is available here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11380
assigned to @iamphill
assigned to @lbennett
added blocked label
mentioned in issue #2427