Skip to content

Resolve "Remove duplicated config code for filtered search dropdowns" (EE Version)

What does this MR do?

EE version of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11512

  1. Refactor duplicated code that is used to determine whether the hint dropdown should show certain dropdown items. Previously, there was code inside app/views/shared/issuable/_search_bar.html.haml and app/assets/javascripts/filtered_search/filtered_search_token_keys.js to configure which dropdown to show in the hint dropdown
  1. Refactor code so that the tokenkeys is determined in filteredSearchManager and passed down. In EE, we pass a different tokenkeys file that includes the weight. In the current implementation, there were some weird side effects in EE where weight filters weren't being displayed correctly because of this

Are there points in the code the reviewer needs to double check?

Shouldn't be

Why was this MR needed?

technical debt

Screenshots (if relevant)

None

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/32563

Edited by username-removed-408677

Merge request reports