Skip to content

Geo: fix removal of repositories from disk on secondary nodes

Gabriel Mazetto requested to merge 2701-geo-fix-repositories-removal into master

What does this MR do?

  • Implements tests to cover repository removal on secondary nodes
  • Fix the regression

Are there points in the code the reviewer needs to double check?

Check if proposed workaround for the lack of repository_storage metadata in the Hook notification is good enough or not.

I'm using the gitlab_shell reference from the Project to check existence of the repository, is that compatible with current/future gitaly ?

Why was this MR needed?

There was a regression after the introduction of multiple repository storages that got unnoticed because we lacked spec coverage.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #2701 (closed)

Edited by Gabriel Mazetto

Merge request reports