Fix GitLab check: Problem with Elastic Search

Gabriel Mazetto requested to merge 2757-fix-elasticsearch-check into master

What does this MR do?

  • Adds exception handling the the SimpleExecutor (will be backported to CE)
  • Fix ElasticSearch #check? logic
  • Adds #show_error linking to documentation

Are there points in the code the reviewer needs to double check?

Are the versions we are supporting correct? (5.1 - 5.3)?

Why was this MR needed?

There was a regression with the check migration from old check.rake to the SystemCheck: see #2757 (closed)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #2757 (closed)

Edited by Gabriel Mazetto

Merge request reports