Skip to content
Snippets Groups Projects

Break down ES guide into two separate guides for small and big instances

Merged Valery Sizov requested to merge elasticsearch_doc_improve into master
All threads resolved!

What does this MR do?

Improves ES documentation

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

closes https://gitlab.com/gitlab-org/gitlab-ee/issues/1472

Edited by Valery Sizov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas
  • Nick Thomas
  • Nick Thomas
  • Nick Thomas
  • assigned to @vsizov

  • Thanks @vsizov - the separation makes sense, just a few comments.

  • Is it worth talking about how the number of shards is hardcoded to 5 and including instruction on how to manually change it for large instances?

    Edited by Nick Thomas
  • Do we also want to talk about sidekiq queues, throttling, dedicated sidekiq runners, etc, here? These are all things GitLab.com needs to do to make elasticsearch work, so we should share with the community as much as possible.

    Perhaps it can be deferred to a second merge request once we've actually got GitLab.com working with elasticsearch

    Edited by Nick Thomas
  • Valery Sizov changed title from Rework ES documentation to Break down ES guide into two separate guides for small and big instances

    changed title from Rework ES documentation to Break down ES guide into two separate guides for small and big instances

  • Author Contributor

    @nick.thomas I propose to improve this doc iteratively. All your suggestions make sense to me. Do you want me to create a new issue with all suggestions?

  • Thanks @vsizov. So just the screen / tmux note in this MR, then the rest can go into a new issue :thumbsup:

  • Valery Sizov mentioned in issue #2903

    mentioned in issue #2903

  • Author Contributor

    @nick.thomas We have an issue regarding number of shard hardcoded https://gitlab.com/gitlab-org/gitlab-ee/issues/2087

  • Valery Sizov resolved all discussions

    resolved all discussions

  • assigned to @axil

  • Author Contributor

    @axil Please take a look & merge if you're OK with this.

  • LGTM now :thumbsup:

  • Valery Sizov mentioned in issue #2907

    mentioned in issue #2907

  • Author Contributor

    @victorcete Would you mind to review changes?

  • @vsizov I added a small comment about the number_of_replicas but apart from that LGTM too!

  • Valery Sizov resolved all discussions

    resolved all discussions

  • Author Contributor

    OK, this doc was hardly changed in parallel https://gitlab.com/gitlab-org/gitlab-ee/commit/334c91085bb340e5bf9c7e9e11f1c2c6ed8b6df3 so I need to re-apply all the changes basically...

  • Valery Sizov resolved all discussions

    resolved all discussions

  • Valery Sizov added 475 commits

    added 475 commits

    • 23d4001a...16b3dfe7 - 474 commits from branch master
    • cca9563f - Break down ES guide into two separate guides for small and big instances

    Compare with previous version

  • @vsizov sorry about that :/ I'll review asap.

  • merged

  • assigned to @vsizov

  • Author Contributor

    @axil Feel free to push fixes.

  • Please register or sign in to reply
    Loading