Skip to content
Snippets Groups Projects

Fix access checks for rebasing an MR

Merged username-removed-443319 requested to merge fix-rebase-permissions-check into master

What does this MR do?

When checking whether to show the rebase button, we (correctly) see if you can push to the source branch.

The controller, however, was checking if you could merge to the target branch, which is a totally different thing!

Are there points in the code the reviewer needs to double check?

Don't think so.

Why was this MR needed?

This has never worked properly :grimacing: https://gitlab.com/gitlab-org/gitlab-ee/issues/2891#note_34616824

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/2891.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading