Skip to content
Snippets Groups Projects

Handle project deletions in Geo::LogCursor

Merged Stan Hu requested to merge sh-geo-cursor-delete-events into master
All threads resolved!

The simplest change here is to remove projects with the cursor, and this duplicates the current functionality used in system hooks.

However, until we solve gitlab-org/gitlab-ce#28283, there's a chance we could accidentally delete another project that was created with this name.

Edited by Stan Hu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @stanhu Thanks! The code looks good! I left some minor comments.

  • Stan Hu added 381 commits

    added 381 commits

    • 8a6f510d...b6326824 - 379 commits from branch master
    • 08aaebaa - Handle project deletions in Geo::LogCursor
    • 7619ed3e - Add specs for deleting projects via Geo::LogCursor

    Compare with previous version

  • Stan Hu added 155 commits

    added 155 commits

    • 90521d63...c96dadf9 - 154 commits from branch master
    • bc3ec5d9 - Handle project deletions in Geo::LogCursor

    Compare with previous version

  • Stan Hu resolved all discussions

    resolved all discussions

  • Author Maintainer

    I'll add another MR to remove the handling of the destroy_project system hook event.

  • assigned to @rspeicher

  • Stan Hu unmarked as a Work In Progress

    unmarked as a Work In Progress

  • assigned to @stanhu

  • Stan Hu
  • Stan Hu added 526 commits

    added 526 commits

    • bc3ec5d9...5a9b6b5e - 525 commits from branch master
    • b1288722 - Handle project deletions in Geo::LogCursor

    Compare with previous version

  • Stan Hu resolved all discussions

    resolved all discussions

  • assigned to @rspeicher

  • Stan Hu changed the description

    changed the description

  • @stanhu LGTM, just needs a rebase. :thumbsup:

  • assigned to @stanhu

  • Stan Hu added 363 commits

    added 363 commits

    • b1288722...451943c0 - 362 commits from branch master
    • 25a46f98 - Handle project deletions in Geo::LogCursor

    Compare with previous version

  • Stan Hu added 363 commits

    added 363 commits

    • b1288722...451943c0 - 362 commits from branch master
    • 25a46f98 - Handle project deletions in Geo::LogCursor

    Compare with previous version

  • assigned to @rspeicher

  • Robert Speicher resolved all discussions

    resolved all discussions

  • Robert Speicher approved this merge request

    approved this merge request

  • Robert Speicher mentioned in commit 6b2fde7e

    mentioned in commit 6b2fde7e

  • Stan Hu mentioned in issue #2827 (closed)

    mentioned in issue #2827 (closed)

  • Please register or sign in to reply
    Loading