Skip to content

Geo: Avoid locking yourself out when adding a GeoNode

Gabriel Mazetto requested to merge patch/geo-avoid-locking-itself-out into master

This is a fix to https://gitlab.com/gitlab-org/gitlab-ee/issues/374 for Geo (#76).

It was possible to lock yourself out on the primary node, as in this example:

  1. My GitLab domain is example.com
  2. I go to the Geo nodes admin area for the first time (no node yet registered)
  3. I register a new node http://example.com but I forget to mark it as primary
  4. The GitLab server is now read-only and I cannot undo my action because of that
  5. Users start e-mailing me death threats because they cannot use GitLab

This should be in 8.5 too. cc @DouweM

Merge request reports