Skip to content
Snippets Groups Projects

Geo - Improve Geo::RepositoriesCleanUpWorker

Merged username-removed-283999 requested to merge geo-repository-clean-up-worker into master
All threads resolved!

What does this MR do?

Check if project repository exists on the secondary node before scheduling removal.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

There is a possibility that a project does not have repository or wiki on a secondary node and we'll just end up enqueuing them on Sidekiq.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #3132 (closed)

/cc @stanhu @brodock @to1ne

Edited by username-removed-283999

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @dbalexandre thanks! One comment about the spec.

  • added 1 commit

    • 0fe8ce94 - Refactoring spec for Geo::RepositoriesCleanUpWorker

    Compare with previous version

  • username-removed-283999 resolved all discussions

    resolved all discussions

  • username-removed-443319 approved this merge request

    approved this merge request

  • username-removed-443319 enabled an automatic merge when the pipeline for 0fe8ce94 succeeds

    enabled an automatic merge when the pipeline for 0fe8ce94 succeeds

  • Nice refactor, thanks @dbalexandre! :100:

  • mentioned in commit 64c15df3

  • Picked into 9-5-stable-ee, will go into 9.5.0 RC2.

  • mentioned in commit 4a990576

  • Please register or sign in to reply
    Loading