Geo - Improve Geo::RepositoriesCleanUpWorker
What does this MR do?
Check if project repository exists on the secondary node before scheduling removal.
Are there points in the code the reviewer needs to double check?
No.
Why was this MR needed?
There is a possibility that a project does not have repository or wiki on a secondary node and we'll just end up enqueuing them on Sidekiq.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #3132 (closed)
Merge request reports
Activity
added 1 commit
- 3d953e3a - Add specs to repositories clean up worker when repository does not exist
marked the checklist item Conform by the style guides as completed
marked the checklist item Conform by the merge request performance guides as completed
@smcgivern Can you review, please?
assigned to @smcgivern
- Resolved by username-removed-283999
@dbalexandre thanks! One comment about the spec.
assigned to @dbalexandre
added 1 commit
- 0fe8ce94 - Refactoring spec for Geo::RepositoriesCleanUpWorker
assigned to @smcgivern
enabled an automatic merge when the pipeline for 0fe8ce94 succeeds
Nice refactor, thanks @dbalexandre!
mentioned in commit 64c15df3
removed Pick into Stable label
mentioned in commit 4a990576