An error occurred while fetching the assigned milestone of the selected merge_request.
Fetch correct key in the settings hash
1 unresolved thread
1 unresolved thread
What does this MR do?
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/3172
/cc @ayufan @ahanselka
Edited by Zeger-Jan van de Weg
Merge request reports
Activity
Filter activity
@zj Do we need test for that?
Actually, now I think about it, we should add a
#valid_configuration
method, which tests at least:- Is the provider set correctly
- Is the remote_dir set
- Do we have an access key
- Do we have a secret
- Do we have a region
If any of those fail, we'll raise/log and fall back to local storage
98 98 end 99 99 100 100 def fog_directory 101 self.class.object_store_options.remote_directory 101 self.class.object_store_options.object_store.remote_directory
Please register or sign in to reply