Add missing import statements

What does this MR do?

Add missing important statements that caused JavaScript to crash on several pages.

What are the relevant issue numbers?

fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/3268

added 1 commit

• b85b0365 - Add missing import statements

Compare with previous version

@timzallmann can you please review?

assigned to @timzallmann

@stanhu asked me to review this

assigned to @ClemMakesApps

I'm not able to reproduce this locally

Is this problem intermittent?

It's consistent for me when I load /admin/geo_nodes on my branch, which I rebased from master yesterday.

@ClemMakesApps For me it was happening when editing a merge request or when going to the repository settings of a project.

For me it was happening when editing a merge request or when going to the repository settings of a project.

I tested on /admin/geo_nodes and settings/repository on latest master and it didnt seem to have any problems

I'll have to try editing a merge request

@ClemMakesApps it happened to me with 26e1561d78 but it doesn't happen in 1a8ee80e0f anymore.

@stanhu can you confirm this has magically been fixed in current master?

@winh I merged master into the branch, and I'm still seeing the Mousetrap issue.

What page does Mousetrap happen on?

@ClemMakesApps You can see it in the the /admin/geo_nodes instance that I shared with you earlier.

So I found out in the morning that a couple of comments on 4 issues from yesterday were never posted due to doing at deployment time.

I tried it out yesterday also with EE master and also had not the problem. So this looks like a problem we already saw before. It's when webpack in dev mode is not really sure about globals together with hot-reloading (@stanhu can you try to turn it off with master ?) We didn't see those problems with an actual built, so this is also why it works for some and for some not as it looks that webpack is doing those packages on a dev in a not consistent order if it doesn't have specific imports for different pages/views.

So how you did it by adding additional imports it's perfect, on one hand, it tells webpack to have by example Moustrap ready for that view and on the other hand when we might have Mousetrap, in a hopeful future, not as a global we then already have a specific import.

So the actual code here LGTM, i am not sure if it fixes all of your problems now @stanhu ?

@timzallmann Yes, the changes here appear to solve the problems I was facing.

approved this merge request

merged

mentioned in commit 1c78b847

@stanhu thx for confirmation, then lets merge

I have to wonder, do we need these changes in CE too?

I have to wonder, do we need these changes in CE too?

@stanhu the problems didn't occur to me in CE but it wouldn't hurt to have the imports there either...

@timzallmann should I create another merge request for CE?

I think to be consistent, it can't hurt to include it in both. Let's avoid merge conflicts that way.