Resolve "Promote Advanced Global Search"

What does this MR do?

It promotes advanced search for local instances. If the feature is not available to that user we are now showing on the result page a dismissal promotion. The basic rules of how and what to show for promotions were already established & extensively reviewed here : gitlab-org/gitlab-ee!2540 This MR is following and applying the same patterns here.

Are there points in the code the reviewer needs to double check?

This is now only for local instances as .com has not yet ES.

Why was this MR needed?

To promote our awesome EE features to all the people who don't have them yet.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes #2978 (closed)

assigned to @timzallmann

@hazelyang + @mydigitalself :

I had to move it above the result count so that it is also shown when we have no results.

unmarked as a Work In Progress

added frontend label

changed milestone to %10.0

changed the description

@timzallmann Thanks! Your reason makes sense to me. However, it looks a little weird if the promotion is above the result count.

Do you think it's possible that we show We couldn't find any results matching git message in the result count bar if there are no results? So the promotion can show under the result count.

You were right it looks weird, i duplicated it now in the template. We have it simply now at 2 positions. Now it looks like originally planned.

added 218 commits

• 298259ef...f915aca0 - 213 commits from branch master
• 5c8967a8 - Implemented Advance Search Promotion
• 598b7843 - Implemented Advance Search Promotion Specs
• 8dd97879 - Added actual searching to the spec test
• ec688ec9 - Remove Trailing Whitespace
• 539753ca - i18 + Adaptions to position + CSS

Compare with previous version

assigned to @iamphill

@iamphill another one coming your way (last one ;-))

@timzallmann Looks great! Thanks!

Is this correct?

assigned to @timzallmann

Oh no, the alignment broke through the other promotion merge. Fixed :

resolved all discussions

assigned to @iamphill

approved this merge request

canceled the automatic merge

merged

mentioned in commit dd72822b