WIP: Resolve "Saved configuration for issue board"
What does this MR do?
Saved config for issue boards - #2518 (closed)
Add an 'Edit board' button to EE Issue Boards to filter by Milestone, Assignee, Labels or Weight
Todo, approximately in order of importance
Frontend
-
update milstone_select spec, add spec for other form elements -
show placeholder text when board filters are applied
Backend
-
update assignee, labels and weight when adding an issue to a board (if they're present on the board) -
update assignee, labels and weight when creating an issue within a list -
when “Removing from board” (one issue), clean Assignee, Labels and Weight (if they're present on the board) -
Check feature_available?(:scoped_issue_board)
checks only filtering-outmilestone_id
param -
Check if users and labels being returned on board config work accordingly for group boards -
Remove author from board (will not go for this release) -
Address comments
Extras
-
Update docs (it was extended to other fields) -> http://localhost:3001/help/user/project/issue_board.html#board-with-a-milestone -
Unlicensed user cannot see "View board" button -
Complete feature tests (ongoing) -
"No Milestone" filter is not working -
"No weight" / "Any weight" filter is not working
Broken pipelines
-
https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/35117442 -
https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/35113132 -
https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/35113903 -
https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/35113093 -
https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/35112207
Are there points in the code the reviewer needs to double check?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #2518 (closed)
Merge request reports
Activity
added 958 commits
-
c472e8f6...7400ba31 - 910 commits from branch
master
- 0c196e76 - move board crud to a modal
- 84d1dfcb - use dialog component
- e3c4947e - Add migrations
- 54cae7e6 - use popup dialog component and move Edit button outside dropdown
- b63dfe41 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ee into issue-board-edit-modal
- 91a647ea - move edit form to .vue
- ad71d446 - Use concurrent way of adding foreign keys
- fea339fa - Rename feature from "issue_board_milestone" to "scoped_issue_board"
- 205fdac9 - Add unique contrainst to labels association
- 52badfa0 - Add initial models/associations
- b3c3b46b - Add changelog
- 778abce6 - clean up modal styles
- fd0dc53f - start separating milestone and dropdown components
- 7d293b9f - rename board form
- 0f1e3360 - Merge remote-tracking branch 'origin/2518-persisted-issue-boards-filter-be' into edit-board
- 4b730f2b - add readonly check of !canAdminBoard is false
- 3c58dda6 - Simplify relations by not creating a 1:1 relation with BoardFilter
- 08f46526 - Make Mysql happy with rollback
- 4359dfe7 - Remove extra space
- d80dd3b5 - Remove milestone foreign-key on boards
- fa0d0bf2 - Allow assignee, author and weight on EE board creation action
- cc5e7b63 - clean up styles
- 51004d0e - Merge branch 'issue-board-edit-modal' into edit-board
- 9b802ed9 - Merge branch '2518-persisted-issue-boards-filter-be' of…
- 32ac090e - re-add check icon for selected item
- 58565ac5 - Merge branch 'issue-board-edit-modal' into edit-board
- 80f4fa87 - move edit test
- d867b9a7 - fix lints
- 80496129 - Add migrations
- 2e19d8ff - Use concurrent way of adding foreign keys
- 29b90ce8 - Rename feature from "issue_board_milestone" to "scoped_issue_board"
- a6d39980 - Add unique contrainst to labels association
- 2fe07e90 - Add initial models/associations
- de2a5243 - Add changelog
- 06cb03b3 - Simplify relations by not creating a 1:1 relation with BoardFilter
- 8951898d - Make Mysql happy with rollback
- 6e901ba7 - Remove milestone foreign-key on boards
- c6570947 - Allow assignee, author and weight on EE board creation action
- e9154f46 - Allow sending label ids on board creation/update
- f753e99b - Make static-analysis happy
- 6ad9a66b - add weight select dropdown
- 605c9059 - start adding labels select
- 59d29e78 - Merge branch 'issue-board-edit-modal' into edit-board
- 4d2315a3 - Merge branch '2518-persisted-issue-boards-filter-be' of…
- b80403a3 - add weight param to filter bar
- 83941288 - hide locked tokens
- ffc1137e - include author and assignee from board config
- 303d4aef - fix dropdown values not updating non-reactive data
Toggle commit list-
c472e8f6...7400ba31 - 910 commits from branch
@oswaldo I merged the two branches in this one, had some odd conflicts so if it looks incorrect. Feel free to push to this branch.
I haven't been able to get labels to save, even though it was sending label_ids in params.
The two user dropdowns (author/assignee) are currently just text inputs for the ID, figuring out some dropdown complications
marked the checklist item Changelog entry added, if necessary as completed
assigned to @psimyn
mentioned in merge request !2975 (closed)
assigned to @oswaldo
assigned to @psimyn
added 294 commits
-
365350df...6b532527 - 291 commits from branch
master
- 3efbe1d4 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ee into…
- 84cf1644 - fix board delete button
- 1c4c0342 - remove some unused code
Toggle commit list-
365350df...6b532527 - 291 commits from branch
@MadLittleMods are you able to start review of frontend for this please? I have a few remaining TODOs (in description) but only minor things. Thanks!
Edited by Simon Knox