WIP: Resolve "Issues in sub group boards have the incorrect link"
What does this MR do?
Accounts for subgroups in the EE boards issue link base generation.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together
What are the relevant issue numbers?
Closes #3562
Merge request reports
Activity
added Pick into Stable label
assigned to @lbennett
@MadLittleMods could you review? Feel free to reassign. :)
assigned to @MadLittleMods
@lbennett This does work for one sub-group but isn't general for multiple nested sub-groups (add some tests for that as well)
Personal reproduction,
assigned to @lbennett
18 18 def build_issue_link_base 19 19 return super unless @board.group_board? 20 20 21 "/#{@board.group.path}/:project_path/issues" 21 link_base = '/' 22 link_base << "#{@board.group.parent.path}/" if @board.group.subgroup? I am pretty sure there are some helpers available to get the whole path which will include sub-sub-sub groups, etc.
Edited by username-removed-892863-
I spoke to @DouweM and its not possible to do this using rails path helpers. Seems we need to change how this works, but that's a lot for a regression fix...
-
Yah seems its been this way since its addition and hasn't changed since https://gitlab.com/gitlab-org/gitlab-ee/commit/65db35d1f840fe2b40aec0225b6fb61f6c6fbf72
@lbennett This definitely sounds like a path the JSON should just have in full, not something we should build on the frontend.
