Skip to content
Snippets Groups Projects

Fix diffs in text part of email-on-push messages

Closed Stan Hu requested to merge stanhu/gitlab-ee:fix-plaintext-email-diffs into master
  1. Apr 14, 2016
    • Stan Hu's avatar
      Fix diffs in text part of email-on-push messages · d01168a1
      Stan Hu authored
      `safe_diff_files` directly modifies @message.diffs and was being called inside the HTML template
      of the e-mail. By the time the text e-mail rendering occurs, the objects were already
      wrapped by GitLab's diff helpers. This MR makes it explicit that the diff wrapper
      will be used in both the text and HTML e-mail templates.
      
      Closes gitlab-org/gitlab-ce#14497
      d01168a1
Loading