Skip to content
Snippets Groups Projects

Don't expose URL credentials in errors generated by Mirror sync.

Merged Rubén Dávila requested to merge issue_447 into master

REF: #447

With this fix we remove the credentials from the repo URLs that are shown when there is an internal error with Git

Screen_Shot_2016-05-06_at_12.46.13_PM

UPDATE: Now credentials are removed instead of replaced.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reassigned to @rdavila

  • Rubén Dávila Added 1 commit:

    Added 1 commit:

    • 4078146a - Don't expose URL credentials in errors generated by Mirror sync.
  • Reassigned to @rspeicher

  • Author Maintainer

    @rspeicher thanks for the code review, I've updated the MR, can you please review again?

  • Rubén Dávila Added 4 commits:

    Added 4 commits:

    • 4078146a...e63acf95 - 2 commits from branch master
    • 05301226 - Don't expose URL credentials in errors generated by Mirror sync.
    • ed9d77a4 - Merge ImportUrl and UrlCredentialsFilter into a more generic class.
  • Author Maintainer

    @rspeicher I've merged the Gitlab::ImportUrl and Gitlab:: UrlCredentialsFilter into the new Gitlab::UrlSanitizer class, can you please review?

  • Reassigned to @rdavila

  • Rubén Dávila Added 1 commit:

    Added 1 commit:

    • 776f3c1c - Merge ImportUrl and UrlCredentialsFilter into a more generic class.
  • Reassigned to @rspeicher

  • Author Maintainer

    @rspeicher I've updated the MR can you please review?

  • Robert Speicher mentioned in commit 8c599cd0

    mentioned in commit 8c599cd0

  • Robert Speicher Status changed to merged

    Status changed to merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading