Group sync refactor (!507) · Merge requests · GitLab.org / GitLab · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Drew Blessing requested to merge dblessing/gitlab-ee:group_sync_refactor into master Jun 29, 2016

Related to @jacobvosmaer-gitlab https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/500#note_12679169 in !500 (closed)

This is a possible idea for refactoring group sync to be more logical.

A single group would be synced in Gitlab::LDAP::Sync::Group.
Loop over all group links and invoke the single group sync from Gitlab::LDAP::Sync::Groups.
Hourly sync of all groups will happen in a worker. Worker will invoke the Gitlab::LDAP::Sync::Groups class.
On-demand sync of a single group by either admin or group owner/masters will kick off another worker that invokes the Gitlab::LDAP::Sync::Group class.

Does this seem more logical, Jacob? My hope is that it splits things out enough that it's easier to follow.