WIP: Fix of 'Commits being passed to custom hooks are already reachable when using the UI'
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/19771
This MR changes the way how we create commit, we create it directly in the branch and we don't use temporary ref anymore. This also works similar to how git-receive-pack
works so it's a natural way to create commit.
-
Replace reference to gitlab_git gem in Gemfile when one released with our change (https://gitlab.com/gitlab-org/gitlab_git/merge_requests/102) -
Specs -
Fix CreateBranchService -
Back-port to CE (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5337)
Merge request reports
Activity
Added 1 commit:
- 098486e7 - Fix create branch service
Added 1 commit:
- 04348e02 - Fix of 'Commits being passed to custom hooks already reachable when using the UI'
Added 24 commits:
-
04348e02...1c04b072 - 23 commits from branch
master
- d272eda5 - Fix of 'Commits being passed to custom hooks already reachable when using the UI'
-
04348e02...1c04b072 - 23 commits from branch
Added 1 commit:
- cfbd8d81 - Fix of 'Commits being passed to custom hooks already reachable when using the UI'
Added 14 commits:
-
cfbd8d81...8bfb7369 - 13 commits from branch
master
- 3ef1bb48 - Fix of 'Commits being passed to custom hooks already reachable when using the UI'
-
cfbd8d81...8bfb7369 - 13 commits from branch
Reassigned to @dzaporozhets
@dzaporozhets Please review. Specs are failing because rubocop does not like Gemfile, I will revert it anyway when gitlab_git MR is merged. So nevermind.
Edited by Valery Sizov@vsizov looks good to me.
Added 1 commit:
- 7cf6f50f - Fix of 'Commits being passed to custom hooks already reachable when using the UI'
Marked the task Replace reference to gitlab_git gem in Gemfile when one released with our change (https://gitlab.com/gitlab-org/gitlab_git/merge_requests/102) as completed
Reassigned to @vsizov
Milestone changed to %8.11