Skip to content
Snippets Groups Projects

Don't pass a current user to Member#add_user in LDAP group sync

All threads resolved!

See the individual commits for explanation of the changes.

This is part of the fix for gitlab-org/gitlab-ee#1159.

CE backport for the change in Members::ApproveAccessRequestService is at gitlab-org/gitlab-ce!7168. /cc @stanhu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reassigned to @rymai

  • Maintainer

    Looks good to me. Let's get this in a patch release ASAP.

  • username-removed-128633 Resolved all discussions

    Resolved all discussions

  • Reassigned to @stanhu

  • Reassigned to @rymai

  • @stanhu @vsizov I force-pushed the fix after @vsizov remark which was valid!

  • Added 2 commits:

    • 8018c125 - Allow Members::ApproveAccessRequestService to accept a new :force param
    • 8e748bdb - Don't pass a current user to calling Member#add_user in LDAP group sync

    Compare with previous version

  • username-removed-128633 Changed title: Don't pass a current user to calling Member#add_user in LDAP group syncDon't pass a current user to Member#add_user in LDAP group sync

    Changed title: Don't pass a current user to calling Member#add_user in LDAP group syncDon't pass a current user to Member#add_user in LDAP group sync

  • Reassigned to @stanhu

  • Stan Hu Enabled an automatic merge when the build for 8e748bdb succeeds

    Enabled an automatic merge when the build for 8e748bdb succeeds

  • Stan Hu Status changed to merged

    Status changed to merged

  • Stan Hu Mentioned in commit 8e9eee0a

    Mentioned in commit 8e9eee0a

  • Stan Hu Mentioned in commit 11562fef

    Mentioned in commit 11562fef

  • Maintainer

    Picked into 8-13-stable, will go into 8.13.2.

    Edited by Stan Hu
  • Stan Hu Removed ~149424 label

    Removed ~149424 label

  • Marin Jankovski mentioned in commit aa6aa2e9

    mentioned in commit aa6aa2e9

  • Please register or sign in to reply
    Loading