Update validates_hostname to 1.0.6 to fix a bug in parsing hexadecimal-looking domain names
validates_hostname <= 1.0.5 has a bug that breaks hostnames that could be interpreted as hexadecimal numbers. This is fixed in https://github.com/KimNorgaard/validates_hostname/pull/7
Update our version of the gem to one that includes this fix, and add a test for it.
/cc @cpallares @0x7cc
Can we get this into 8.15 do you think?
Closes #827 (closed)
Merge request reports
Activity
added 721 commits
-
b46d5756...f490a736 - 720 commits from branch
gitlab-org:master
- a930645f - Update validates_hostname to 1.0.6 to fix a bug in parsing hexadecimal-looking domain names
-
b46d5756...f490a736 - 720 commits from branch
assigned to @godfat
@nick.thomas I didn't audit what's changed for validates_hostname between 1.0.5 and 1.0.6, but this looks good to me, thanks!
enabled an automatic merge when the build for a930645f succeeds
mentioned in commit 699c6cad
Thanks @nick.thomas :)
mentioned in commit 1cb1e1e3