Skip to content
Snippets Groups Projects

Fix an exception in notifier when message is empty

1 unresolved thread

If there is an issue sending a notification the callback is invoked with just the error argument and no message. Then in the callback checkActivationNotifierResponse is called with the message argument without checking first if it is valid causing an exception.

Before this change the error shown was: "Problem initializing notification" "TypeError: Cannot read property 'trim' of undefined

The real error was masked by the exception: "Problem with notification" "Error: not found: notify-send"


Closes https://gitlab.com/gitlab-org/gitter/desktop/issues/185

Edited by username-removed-892863

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • username-removed-892863 changed the description

    changed the description

  • Please register or sign in to reply
    Loading