Skip to content

Fix an exception in notifier when message is empty

username-removed-1177921 requested to merge agrare/desktop:fix_issue_185_notifier_bug_when_message_is_empty into master

If there is an issue sending a notification the callback is invoked with just the error argument and no message. Then in the callback checkActivationNotifierResponse is called with the message argument without checking first if it is valid causing an exception.

Before this change the error shown was: "Problem initializing notification" "TypeError: Cannot read property 'trim' of undefined

The real error was masked by the exception: "Problem with notification" "Error: not found: notify-send"

Closes https://gitlab.com/gitlab-org/gitter/desktop/issues/185

Edited by username-removed-892863

Merge request reports