Ctrl + F Search Hijacking is evil

Created by: qubodup

Hi,

When an experienced user wants to search the currently viewed chat for a word, gitter says "no way".

Commented video: http://youtu.be/B-oaPbnUxiQ

Steps to reproduce:

1. go to a chat and press ctrl+f and enter a search term that was used in said chat. Press enter.

Expected result: quickly highlight and jumping through result of that term in the current chat.

Actual result: First nothing happens for seconds. Then a new chat opens.

Solution: You can react to the user using ctrl+f and inform them of what tools the site offers but you shouldn't hijack the key combination.

Created by: kotp

Created by: jrafanie

I don't know that only advanced users expect the browser's find to work. I would expect gitter to use a different key combination or at the very least, make it Opt in. As it is now, I can't find anything quickly even 3 or 4 pages up in the current room.

Created by: garth

Same issue on OS X with cmd+F.

+1

On a non-sighted user note, with a screen reader: NVDA has NVDA + Ctrl + F that lets you find on page.

This interaction needs improvement for keyboard users regardless of the Ctrl + F binding though and I separated it into this issue: https://github.com/gitterHQ/gitter/issues/1176

The search shortcut has moved to Ctrl + S

I agree that in the browser version of gitter, hijacking the search is not cool. However, in the app version of gitter (at least over Mac), literally nothing happens when you use ctrl+F. Now that I know that ctrl+s will get to the deep search functionality I guess that is better than having no key combination. However, more often than not, I want to search the thread within the last 5-10 screens.