WIP: Remove patches, enable Prometheus exporters and configure them for external PG, Redis.
Remove Git Hooks patch, it's ConfigMap, and references.
Enable and configure additional Prometheus exporters in 8.17:
- gitlab-monitor
- redis_exporter
- postgres_exporter
Two bugs still in RC3:
- We are unable to modify the listen address of Prometheus, so it is currently inaccessible remotely since it is listening only on localhost.
- gitlab-monitor does not support modifying the listen port, so its metrics are not included.
Notes:
- Since Redis and Postgres are running in their own independent containers in this demo, additional configuration was required.
Merge request reports
Activity
@joshlambert Can you explain some of this a bit more? Why are the exporters in their own containers? Aren't they included in Omnibus, and therefore in the main container? Looking at the changes in this MR, I don't see how where these separate containers are created.
How does the listen port affect the demo, which relies on hitting
https://prometheus.example.com
?@markpundsack The exporters are indeed running in the GitLab container along with Prometheus, but Redis and PG are currently running in their own containers. This means we need to tweak
gitlab.rb
so the exporters know where to find Redis and Postgres.The listen port issue means hitting
https://prometheus.example.com
fails, but that should (needs to) be getting fixed for final release of 8.17. See https://gitlab.com/gitlab-org/omnibus-gitlab/issues/1970 for more info.The gitlab-monitor port fix should be ready for RC4.
Edited by Joshua LambertClosing as this is superseded by !26 (merged).