Release Documentation Issues
I've been trying to get my head around building an omnibus package for my own fork and I finally appear to be getting somewhere. Today I tried to get it to build a branch and was reading and trying to roughly follow the steps in https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/doc/release/README.md.
The first thing that looks a bit wrong is the following:
# For 6.6.0 CE:
support/set-revisions v1.2.3 v1.2.3 1.2.3
# For 7.14 EE:
support/set-revisions --ee v1.2.3-ee v1.2.3 1.2.3
Apart from the obvious point that the version numbers don't change, there was a change recently to append the v at the beginning the gitlab and gitlab-shell version numbers, https://gitlab.com/gitlab-org/omnibus-gitlab/commit/01df877a56a1663af0a9895153ae385a56e9707c, but the set-revisions script doesn't appear to take this into account so is writing out the VERSION and GITLAB_SHELL_VERSION file with a v in them.
The second issue is that the section about committing the changes says to
git commit -v config/software
But I think there was a change a little while back to just use the VERSION files and nothing should be changing in config/software anymore.