OmnibusHelper#service_up? returns `true` if service is down
We saw this in !1401 (merged):
It appears to try to run /opt/gitlab/embedded/bin/sv status geo-postgresql
, but this returns 0 because even if the service is down, since there are no errors:
stanhu@stanhu-geo-secondary:/opt/gitlab$ sudo /opt/gitlab/embedded/bin/sv status geo-postgresql
down: geo-postgresql: 251000s, normally up; run: log: (pid 14999) 350709s
stanhu@stanhu-geo-secondary:/opt/gitlab$ echo $?
0
From sv man page:
sv exits 0, if the command was successfully sent to all services, and, if it was told to wait, the command has taken effect to all services.
I think we may want to parse the output to make sure it starts with run:
.
/cc: @balasankarc