Make geo-postgresql specs track template changes better

#2191 (closed) quietly happened because the postgresql.conf.erb template changed but the geo-postgresql spec did not detect this. We should refactor the specs so that changing the template will cause a spec failure in the geo-postgresql recipe if the attribute is not added there. Or make reasonable defaults that just work.

/cc: @brodock

mentioned in merge request !1500 (merged)

@stanhu Ideally we should be able to reuse the default attributes from the original recipe, so when this type of change happens we inherit the change. So let's say that in chef terminology the "default" attribute cames from the original recipe, and we ours will be the "normal" attributes (so we "override" anything we want, but fallback to the original attribute).

Reference:

I don't know how to do that in Omnibus, do you know @marin @twk3?

I don't see how we can check in specs for this type of change, unless we compare a fixture file with the output file from the template, which is not ideal.

Not sure if this will work because they are in separate files, but can we just dup the postgres defaults for the geo postgres. Similar to what we do for the different nginx configs?

default['gitlab']['geo-postgresql'] = default['gitlab']['postgresql'].dup
default['gitlab']['geo-postgresql']['enable'] = false

I have an idea I need to test: what If we require or load the other attribute file from the gitlab-ee/attributes/ file? In theory it should work.

Looks like there is include_attributes: https://blog.chef.io/2013/02/05/chef-11-in-depth-attributes-changes/, if it works as expected, we can re-use the attributes from the first cookbook and just define the differences with force_default[] or the shorter version: default![].

Does anyone see any concern?

added geo label

@brodock Why not just use .dup like @twk3 suggested? We already do that in other places in the cookbook.

@marin sorry I missed @twk3 suggestion completely. Can I do that inside the attributes file or do I need to make it in the recipe itself?

@brodock You can do it in the attributes file, check for example registry-nginx.

Happened similar issue in %9.3 : #2528 (closed). After finishing #2481 (closed) I will prioritize this.

assigned to @brodock

changed milestone to %9.4

Maybe this is simpler @brodock https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2540 ?

mentioned in issue #2540

mentioned in merge request !1700 (merged)

closed via merge request !1700 (merged)

mentioned in commit 82bcc5c5