Registry internal key populate should be in Rails recipe

Part of https://gitlab.com/gitlab-com/infrastructure/issues/2149

When Registry is disabled on a node AND we want to use a custom certificate for the Rails <-> Registry communication, the key cannot be created by the package. This is because we won't be running the registry recipe which would normally create this file. We should move this part to gitlab-rails recipe and create it if node['registry']['internal_key'] is set and node['gitlab']['gitlab-rails'['registry_enabled']=true.

/cc @omame @balasankarc

mentioned in issue gitlab-com/infrastructure#1993 (closed)

mentioned in issue gitlab-com/infrastructure#2149 (closed)

added Unscheduled label

assigned to @balasankarc

@balasankarc Could you check this out?

created branch 2558-registry-internal-key-populate-should-be-in-rails-recipe

mentioned in merge request !1738 (merged)

A package is available here - https://omnibus-builds.s3.amazonaws.com/ubuntu-xenial/gitlab-ce_8.1.0%2Bgit.3156.13cfe2d-rc1.ce.0_amd64.deb

I gave it a try locally and the key file was generated when registry_enabled was set to true. @omame Will be testing it from his side.

@marin Can you check if this is actually what is required, as per the issue description? - https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1738

I just tested it on api01.stg.gitlab.com and I can confirm it does the trick.

Great job @balasankarc!

closed via merge request !1738 (merged)

mentioned in commit 01f75c64

mentioned in commit fd5d9457

mentioned in commit e6ca9711

mentioned in commit 7f95831e

mentioned in issue gitlab-com/infrastructure#2838 (closed)