Configuring object store for artifacts fails

ZD: https://gitlab.zendesk.com/agent/tickets/80678

If you add the lines, reconfigure fails:

gitlab_rails['artifacts_enabled'] = true
gitlab_rails['artifacts']['object_store_enabled'] = true

================================================================================
Recipe Compile Error in /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab-ee/recipes/default.rb
================================================================================

NoMethodError
-------------
undefined method `[]=' for nil:NilClass

Cookbook Trace:
---------------
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/config.rb:21:in `from_file'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/default.rb:26:in `from_file'
  /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab-ee/recipes/default.rb:18:in `from_file'

Relevant File Content:
----------------------
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/config.rb:

 14:  # See the License for the specific language governing permissions and
 15:  # limitations under the License.
 16:  #
 17:  
 18:  Gitlab[:node] = node
 19:  
 20:  if File.exists?('/etc/gitlab/gitlab.rb')
 21>>   Gitlab.from_file('/etc/gitlab/gitlab.rb')
 22:  end
 23:  
 24:  node.consume_attributes(Gitlab.generate_config(node['fqdn']))
 25:  
 26:  # If is EE package, load EE config
 27:  if defined?(GitlabEE) == 'constant'
 28:    node.consume_attributes(GitlabEE.generate_config)
 29:  end
 30:  

Platform:
---------
x86_64-linux

I also noticed a possible typo in https://docs.gitlab.com/ee/administration/job_artifacts.html#using-object-storage: should it be object_store_remote_directory instead of object_store_directory?

/cc: @zj, @axil

added CI/CD label

Artifacts support was only added with 9.3. The customer is on an earlier version. We have also added a better way of displaying the error message when the key is invalid, this is what let me to the conclusion.

I tried this on 9.4.2.

The other place where this can go wrong is the nesting of the variable. I'll check in a minute

The other place where this can go wrong is the nesting of the variable. I'll check in a minute

I also have a question about the documentation. See the description.

Confirmed, this is wrong. Sadly, this was missed during the review. We will need to fix this and backport the fix to 9.3 and 9.4.

removed CI/CD label

added bug label

changed milestone to %9.5

/cc @gitlab-build-team

mentioned in issue gitlab-com/infrastructure#2387

cc @zj

assigned to @balasankarc

mentioned in merge request !1816 (merged)

marked this issue as related to gitlab-com/infrastructure#2387

closed via merge request !1816 (merged)

mentioned in commit 929fae37

mentioned in commit 984fa7d9