PostgreSQL detection and upgrading since 10.0.0-rc5 (Ubuntu 16.10)

Initially coming from 9.5.4 with postgresql 9.6

When installing rc5 over rc4 PostgreSQL upgraded the database and advised to delete the old data dir after verifying all works.

Installing rc6 now shows:

Checking for an omnibus managed postgresql: OK Checking if we already upgraded: NOT OK Checking for a newer version of PostgreSQL to install: NOT OK No new version of PostgreSQL installed, nothing to upgrade to Ensuring PostgreSQL is updated: OK

GitLab itself is up and running.

@swiffer I believe it is already fixed by https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1954 . Will be in RC6.

but post install check still seems to be broken

Checking for an omnibus managed postgresql: OK
Checking if we already upgraded: NOT OK
Checking for a newer version of PostgreSQL to install: NOT OK
No new version of PostgreSQL installed, nothing to upgrade to
Ensuring PostgreSQL is updated: OK

Functionality wise, this is what we expect to see. There is nothing to upgrade to at the moment so we move on. But the output could be improved a bit.

• The 'if we already upgraded' check should be moved after the check for something to upgrade to.

• We might consider not having the 'newer version' check print OK or Not OK. It isn't an error that there isn't something to upgrade to at the moment.

changed milestone to %10.0

added postgresql label

@ibaum those improvements sound good to me. And are probably worth putting in a 10.0 patch. cc\ @joshlambert

Ok, all fine if it's intended behavior. "NOT OK" ist confusing so should be improved. Thanks for clarification.

Just did an omnibus upgrade from apt on 16.04 and I get the same error, as well as gitlab showing unhealthy in the health tab of the admin panel. See #2805 (closed)

@ibaum @twk3 I agree we should clean up these lines, as they are pretty misleading.

The re-ordering sounds good, but can output more descriptive messages for these? "NOT OK" sounds like an error, but it really isn't.

For example when checking for an upgrade, could we print something like "No upgrade available".

assigned to @ibaum

created branch 2800-postgresql-detection-and-upgrading-since-10-0-0-rc5-ubuntu-16-10

mentioned in merge request !1961 (closed)

mentioned in merge request !1962 (merged)

mentioned in commit f78a22d1

closed via merge request !1962 (merged)

mentioned in commit 1248e09a

mentioned in commit b5a6d158