Remove NodeJS as a production dependency

This MR coincides with gitlab-ce!8831 to allow the gitlab omnibus to be run without node as a dependency.

This is done by compiling frontend assets in such as way as to be URL-agnostic. The assets can be compiled once and served from any URL without needing to be recompiled when modifying the external_url setting, if one chooses to do so. AFAICT this use case was the only reason for compiling node within the omnibus package in the first place.

See the discussion in #1874 (closed)

Closes #1874 (closed)

added 1 commit

• 0aca30b2 - prevent ExecJS from complaining when no JS runtime is available in production

Compare with previous version

unmarked as a Work In Progress

assigned to @marin

this should be ready for merge once it has been tested to the build team's satisfaction

Note that this updates all rake task references to the newly namespaced gitlab:assets:* task names. As a result this will only work with GitLab CE master after b78d06b7.

added 1 commit

• dad96a2a - install node modules and set node env prior to compiling assets

Compare with previous version

mentioned in issue #1874 (closed)

mentioned in merge request !1224 (closed)

changed milestone to %8.17

@mikegreiling I've tried 2 cases, upgrade an instance without relative url and with and seems to be working Few comments after which we can merge :)

added 1 commit

• e2ff1196 - address documentation issues

Compare with previous version

added 1 commit

• ee618ba9 - address documentation issues

Compare with previous version

added 1 commit

• f93d8cfc - address documentation issues

Compare with previous version

resolved all discussions

mentioned in commit 7d22e0a8

merged

Let's do this

huzzah!

mentioned in issue #1855 (closed)

mentioned in issue #1921 (closed)

Cool, great work @mikegreiling!

mentioned in issue #1884 (closed)

mentioned in issue gitlab#8073