Registry aws go 1 8 fix
Fixes: https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2350
I have forked docker distribution here: https://gitlab.com/twk3/docker-distribution and updated the aws-sdk-go
dependency, using the release/2.6
branch. I updated it to the same version that they are using in master, to ship in the 2.7 release. Which is aws-sdk-go 1.6.12
My change is in the https://gitlab.com/twk3/docker-distribution/tree/bump-aws-version branch
- We should move my fork into a gitlab group so more than just I have access (@marin I don't have access to do this)
- We need to then also mirror it to dev
- Update this MR with the new sources
Merge request reports
Activity
mentioned in issue #2350 (closed)
Build is here if anyone wants to test further: https://dev.gitlab.org/gitlab/omnibus-gitlab/pipelines/49401
added 1 commit
- 1878167a - Checkout the sha with fix for go 1.8 with aws sdk dependency.
@twk3 I just checked out the branch from your fork and pushed it to our mirror. No need to create a new project for this.
changed milestone to %9.2
enabled an automatic merge when the pipeline for 1878167a succeeds
mentioned in commit fd2d8f79
mentioned in commit 1c804dc4
mentioned in commit 35d8b153
@twk3 Great! How do we handle security backports? I'm concerned that rebuilding packages from prior versions will have this same bug.
@stanhu we have versioned build images so we shouldn't see the same bug with go 1.8 in older releases.