Add omniauth sync_email_from_provider configuration
Adds support for omniauth sync_email_from_provider configuration. See issue #2445 (closed).
Closes #2445 (closed)
Merge request reports
Activity
@ryehle Thanks for your contribution! Could you also add a few specs similar to https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/spec/chef/recipes/gitlab-rails_spec.rb#L195-201 so we know we are passing the expected values to the template? We usually check for the default value when a user doesn't specify anything and a value when users sets something in gitlab.rb.
@marin I'm trying to follow the directions in https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/doc/development/README.md to configure a dev environment so I can run the specs. The most recent entries in the referenced nightly builds repository are labeled 8.1.0... What's going on there?
@ryehle I'm not sure what's up with that, but if you're having trouble running the tests locally, there's always CI :)
@marin I've pushed some tests, though I'll need to update them if we're switching to single quotes.
@ryehle Specs look good! I left a comment about the rest :)
The most recent entries in the referenced nightly builds repository are labeled 8.1.0... What's going on there?
Sorry for the confusion. Nightly image versioning is broken ATM (it is reported in #864 (closed)). For the time being, you can check the date of pushing (available next to the package name in the repo page) to figure out the latest package. I've opened !1614 (merged) to add this information to the docs so that future contributors may not be confused.
added 1 commit
- c8f4aa99 - Add omniauth sync_email_from_provider configuration
assigned to @DouweM
changed milestone to %9.3
