Adds support for setting env variables for the Mattermost runtime
If running GitLab with Mattermost behind a corporate internet proxy we need a way to set the corresponding environment variables for the Mattermost runtime environment in /etc/gitlab/gitlab.rb
, e.g.
mattermost['env'] = {"http_proxy" => "my_proxy", "https_proxy" => "my_proxy", "no_proxy" => "my_no_proxy"}
This implementation is similar to the gitlab-workhorse one in commit 32e19c33.
Closes #2521 (closed)
Merge request reports
Activity
mentioned in issue #2521 (closed)
- Resolved by username-removed-1418956
assigned to @marin
@marin this looks fine to me, over to you for review. I don't think this prevents us from moving forward with https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2377.
@twk3 It actually is preventing us from merging this at the moment. We should reach a clear agreement in #2377 before we add more changes. Thanks for your contribution @tjuerge, but we will have to put it on hold until we resolve some outstanding issue. It is likely that your change will go in in some shape or form though :)
mentioned in issue #2377
added blocked label
removed blocked label
changed milestone to %10.0
assigned to @marin
mentioned in commit 674d0531
@tjuerge We will use this change as part of our other MM work, done in https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1877. Thanks for your contribution!
added Community Contribution label