Include a list of other places where the Git version should be updated

Added some comments about all the places that need to be updated when we update the git version in Omnibus, as an attempt to keep them more synchronised.

mentioned in merge request gitlab-build-images!51 (closed)

changed the description

added 54 commits

• 0b91a159...0e641ebb - 53 commits from branch master
• 6c98ed1e - Merge branch 'master' of gitlab.com:gitlab-org/omnibus-gitlab into other-git-version-docs

Compare with previous version

Note, I've just managed to get GitLab-CE, Gitaly updated to git 2.13.0, but this is now behind the install. Let's get it in anyway.

mentioned in merge request gitlab-build-images!54 (merged)

Related:

• https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13351
• https://gitlab.com/gitlab-org/gitlab-build-images/merge_requests/54

assigned to @marin

Wow, I wasn't even aware of all these locations. I'll merge this but we'll need to think of a way of getting this unified otherwise no one will want to upgrade git :)

approved this merge request

merged

mentioned in commit 9474e514

Wow, I wasn't even aware of all these locations. I'll merge this but we'll need to think of a way of getting this unified otherwise no one will want to upgrade git :)

Yeah, that rabbit-hole goes deep!

This is actually something I've been wanting to discuss with the build team. Over time, all git operations in GitLab will go through Gitaly. For this reason it's important that Gitaly is being tested with the same version of git as we're shipping in Omnibus.

(Currently we're testing against git 2.8 -- our 'minimum' version -- and git 2.13 -- our recommended version).

It's possible to envision a scenario where we upgrade to a version of Git that isn't being tested in Gitaly and something breaks in production. It's not likely but it's worth discussing.

@andrewn Let's discuss this in an issue, definitely worth it! For example, we have an issue to upgrade to 2.14 already and we should sync up on that.

mentioned in issue #2706