Skip to content
Snippets Groups Projects

Fix versioning of nightly and branch builds

Merged Balasankar C requested to merge 864-fix-nightly-build-versions into master
All threads resolved!

Closes #864 (closed)

Edited by Balasankar C

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @marin [Copying comment from https://gitlab.com/gitlab-org/omnibus-gitlab/issues/864#note_37067111 so that the discussion happens here.]

    Considering we don't push branch-built packages to packagecloud repo, we won't be having any chance of package collision. So I don't think we need to even consider timestamp. IMO, we can go with +nightly.<pipeline id>.<current commit sha>. Pipeline id will only be increasing, which will take care of newer builds having later version strings.

    Edited by Balasankar C
  • assigned to @marin

  • Maintainer

    Great work @balasankarc! Excited to see this.

  • Balasankar C unmarked as a Work In Progress

    unmarked as a Work In Progress

  • mentioned in issue #864 (closed)

  • Marin Jankovski
  • I am ok with not having the timestamp, it is barely usable anyway.

  • Balasankar C resolved all discussions

    resolved all discussions

  • Marin Jankovski approved this merge request

    approved this merge request

  • Marin Jankovski mentioned in commit 4dc2f3e2

    mentioned in commit 4dc2f3e2

  • Please register or sign in to reply
    Loading