Fix versioning of nightly and branch builds
Closes #864 (closed)
Merge request reports
Activity
changed milestone to %10.0
- Resolved by Balasankar C
- Resolved by Balasankar C
- Resolved by Balasankar C
- Resolved by Balasankar C
@marin [Copying comment from https://gitlab.com/gitlab-org/omnibus-gitlab/issues/864#note_37067111 so that the discussion happens here.]
Considering we don't push branch-built packages to packagecloud repo, we won't be having any chance of package collision. So I don't think we need to even consider timestamp. IMO, we can go with
+nightly.<pipeline id>.<current commit sha>
. Pipeline id will only be increasing, which will take care of newer builds having later version strings.Edited by Balasankar Cassigned to @marin
Great work @balasankarc! Excited to see this.
Branch build: https://dev.gitlab.org/gitlab/omnibus-gitlab/pipelines/58946
Nightly build: https://dev.gitlab.org/gitlab/omnibus-gitlab/pipelines/58981
Triggered build: https://gitlab.com/gitlab-org/omnibus-gitlab/pipelines/10703771
Test pipeline: https://gitlab.com/gitlab-org/omnibus-gitlab/pipelines/10699849
Edited by Balasankar Cmentioned in issue #864 (closed)
- Resolved by Balasankar C
mentioned in commit 4dc2f3e2
mentioned in issue gitlab-com/infrastructure#1944