Move the package attributes from being dynamically created to being

declared.

This causes some duplication for changing the install-dir, you need to change it in the attributes and in the gitlab project file if you want to change it. But we do not intent to change it ourselves, and may just drop the variable entirely in the future.

This MR replaces https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1764