Skip to content

Ensure the pages external_http and external_https elements are always valid YAML

Nick Thomas requested to merge nick.thomas/omnibus-gitlab:2664-fix-pages-custom-domains-disabled into master

.inspect will return invalid YAML in some cases (e.g., "nil" instead of "null"), which breaks the YAML document we're creating.

As JSON is a subset of YAML, using to_json fixes this issue.

I looked into using #to_yaml instead, but it's difficult to get a node, rather than a document, emitted, which makes it unsuitable for interpolating into another yaml document

Closes #2664 (closed)

Merge request reports