Resolve "Update pgb-notify template"

Closes #2703 (closed)

I think this approach is better.

Instead of chef being in charge of rendering the template, gitlab-ctl pgb-notify is. Chef is in charge of generating a json file that can be read in and updated.

Still need to

• On first run, /opt/gitlab/embedded/nodes/FOO.json won't be generated which pgb-notify relies on for some info. We should either remove that requirement, or ignore_errors and assume a consul restart later will work.
• Get gitlab-ctl pgb-notify updating the template from json and command line arguments.
• After a failover, a reconfigure run might break the application. Need to verify this, and find a fix if so.

unmarked as a Work In Progress

added HA Pick into Stable postgresql labels

changed milestone to %9.5

assigned to @marin

mentioned in merge request !1858 (merged)

@ibaum I can't test the change now but I hope you did that as part of the development. I can't say I have something useful to add, most of these changes are a necessary evil.

approved this merge request

resolved all discussions

merged

mentioned in commit 4871a2bd

Picked into 9-5-stable and 9-5-stable-ee, ready for 9.5.5

removed Pick into Stable label

mentioned in commit f8b8ec4d

mentioned in commit c3badf6a