Stop generating / referencing SSH private keys for the git user on Geo primaries

Closes #2750 (closed)

changed milestone to %10.0

added 84 commits

• 2c766d05...a6dbd2b7 - 82 commits from branch master
• 77dd1178 - Creating a Geo primary no longer requires an SSH key
• a9c8a303 - Only generate a private SSH key on Geo secondaries

Compare with previous version

EE MR to match this one: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2861

unmarked as a Work In Progress

changed title from WIP: Stop generating / referencing SSH private keys for the git user to Stop generating / referencing SSH private keys for the git user on Geo primaries

assigned to @brodock

looks good

assigned to @marin

added Pick into Stable label

assigned to @nick.thomas

Thanks @brodock! Marin's on hols. I'll get this to a maintainer Monday, once the EE counterpart is merged.

@twk3 can you review, but not merge until after https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2861 has ben merged?

added Geo label

assigned to @twk3

Looks good @nick.thomas

Please add a Changelog item, and I will get it merged after the EE change makes it in.

assigned to @nick.thomas

added 15 commits

• a9c8a303...9d44ae02 - 12 commits from branch master
• 1a3d2704 - Creating a Geo primary no longer requires an SSH key
• c2f2dcba - Only generate a private SSH key on Geo secondaries
• 5e5a78ea - Add CHANGELOG

Compare with previous version

Thanks @twk3 - changelog added, and !2861 is back under review. I'll check in again on Wednesday.

assigned to @twk3

added 12 commits

• 5e5a78ea...40824b62 - 11 commits from branch master
• c113b2c0 - Merge branch 'master' into '2750-ssh-private-keys'

Compare with previous version

approved this merge request

enabled an automatic merge when the pipeline for c113b2c0 succeeds

merged

mentioned in commit 388453d6

Picked into 10-0-stable and 10-0-stable-ee, will go into 10.0 RC4.

removed Pick into Stable label

mentioned in commit 629e30a8

mentioned in commit b823274f